Port Faster R-CNN to Keras3 by sineeli · Pull Request #2458 · keras-team/keras-cv

sineeli · 2024-06-25T06:39:43Z

What does this PR do?

Port legacy Faster R-CNN to Keras 3

Fix minor bug in ROI Align, make sure to build the shapes for each layer components.

The present PR is modified code of Updating FasterRCNN to use Task API contributed by @ariG23498. Please @ariG23498 any suggestions form your side are appreciated.

sineeli · 2024-06-25T06:54:51Z

Can we make last dimension of the roi_generator.py boxes output have fixed 4 as dimension, any suggestion on how to make it possible ?

Ref:

keras_cv/src/models/object_detection/faster_rcnn/faster_rcnn.py

sineeli · 2024-06-25T07:26:30Z

@VarunS1997 Review for any corrections are fixes required from based code.

Thanks!

ariG23498 · 2024-06-25T07:45:43Z

Hey @sineeli this is so cool! Thanks for taking this up. It was a long time ago and unfortunately I would not be able to give you a thorough review.

What I understand should be green flags are:

The model should follow the Functional API of Keras
It should use the model.fit() API and train on PASCAL VOC

Last I worked on it I could not get every component to comply with the Functional API. If you got that part sorted, you are good to go ^_^

Closes #2012

sineeli · 2024-06-25T18:11:40Z

Hey @sineeli this is so cool! Thanks for taking this up. It was a long time ago and unfortunately I would not be able to give you a thorough review.

What I understand should be green flags are:

The model should follow the Functional API of Keras

It should use the model.fit() API and train on PASCAL VOC

Last I worked on it I could not get every component to comply with the Functional API. If you got that part sorted, you are good to go ^_^

Closes #2012

Yes trying to make it functional, hopefully it will workout!

VarunS1997

Generally, good ideas here and good implementation.

We should definitely, however, implement some of the requested changes.

Also please remember to run keras_cv's linter included under the shell/ directory.

I also will have to come back to this for architecture verification. But, if you have a working colab or similar, that would work as well.

keras_cv/src/models/object_detection/faster_rcnn/rpn_head.py

keras_cv/src/models/object_detection/faster_rcnn/rcnn_head.py

keras_cv/src/models/object_detection/faster_rcnn/feature_pyramid.py

keras_cv/src/models/object_detection/faster_rcnn/faster_rcnn.py

…x format

…g for model saving

- Fix ROI Align ops for torch backend

- Make bounding box test utils use 256,256 image size

… cases

divyashreepathihalli

left some comments to reduce tests sizes.

keras_cv/src/models/object_detection/faster_rcnn/faster_rcnn_test.py

- Add build method for fpn

- Correct YOLOv8 preset test case

divyashreepathihalli · 2024-08-20T21:41:43Z

Excellent work!! Thanks Siva!!

FasterRCNN has been handed off to Divya.

sineeli added 7 commits June 10, 2024 14:54

Base structure for faster rcnn till rpn head

c37ae23

Add export for Faster RNN

973dd6a

add init file

70c7f24

initalize faster rcnn at model level

de67b89

code fix fo roi align

aaebe30

Forward Pass code for Faster R-CNN

0707858

Faster RCNN Base code for Keras3(Draft-1)

cff3b8e

Add local batch size

4f511e9

sineeli commented Jun 25, 2024

View reviewed changes

keras_cv/src/models/object_detection/faster_rcnn/faster_rcnn.py Show resolved Hide resolved

chunduriv requested a review from VarunS1997 June 26, 2024 17:17

chunduriv added the wip working in progress from KerasCV team label Jun 26, 2024

VarunS1997 previously requested changes Jun 28, 2024

View reviewed changes

sineeli added 7 commits July 2, 2024 11:17

Add parameters to RPN Head

0eef933

Make FPN more customizable with parameters and remove redudant code

75c64ca

Compute output shape for ROI Generator

6267a4b

Faster RCNN functional model with required import corrections

1931f02

add clip boxes to forward pass

58dc7f9

add prediction decoder and use "yxyx" as default internal bounding bo…

7c65348

…x format

feature pryamid correction

676fcf1

sineeli requested a review from VarunS1997 July 23, 2024 18:51

sineeli added 6 commits July 29, 2024 08:51

change ops.divide to ops.divide_no_nan

dcea19f

use from logits=True for Non Max supression

2179157

include box convertions for both rois and ground truth boxes

a002c49

Change number of detections in decoder

5953f0a

Use categoricalcrossentropy to avoid -1 class error + added get_confi…

91f21fa

…g for model saving

add basic test cases + linting

abf0b44

kokoro-team removed the kokoro:force-run Runs Tests on GPU label Aug 16, 2024

- Skip Legacy test cases

10b9e76

- Fix ROI Align ops for torch backend

sachinprasadhs added the kokoro:force-run Runs Tests on GPU label Aug 16, 2024

kokoro-team removed the kokoro:force-run Runs Tests on GPU label Aug 16, 2024

sineeli added 2 commits August 16, 2024 11:14

- Remove unecessary import in legacy code to fix lint

e1d89e7

- Correct pytest complexity

58178c6

- Make bounding box test utils use 256,256 image size

sachinprasadhs added the kokoro:force-run Runs Tests on GPU label Aug 16, 2024

kokoro-team removed the kokoro:force-run Runs Tests on GPU label Aug 16, 2024

- FIx Image Shape to 512, 512 default which will not break other test…

1c6125b

… cases

sachinprasadhs added the kokoro:force-run Runs Tests on GPU label Aug 16, 2024

kokoro-team removed the kokoro:force-run Runs Tests on GPU label Aug 16, 2024

divyashreepathihalli reviewed Aug 19, 2024

View reviewed changes

- Lower image sizes for test cases

df56fa6

- Add build method for fpn

sachinprasadhs added the kokoro:force-run Runs Tests on GPU label Aug 19, 2024

kokoro-team removed the kokoro:force-run Runs Tests on GPU label Aug 19, 2024

- fix keras to 3.3.3 version

6b03271

sachinprasadhs added the kokoro:force-run Runs Tests on GPU label Aug 20, 2024

kokoro-team removed the kokoro:force-run Runs Tests on GPU label Aug 20, 2024

sineeli added 2 commits August 20, 2024 11:11

- Generate api

8608516

- Correct YOLOv8 preset test case

- Lint fix

d1f05af

sachinprasadhs added the kokoro:force-run Runs Tests on GPU label Aug 20, 2024

kokoro-team removed the kokoro:force-run Runs Tests on GPU label Aug 20, 2024

- Increase the atol, rtol for YOLOv8 Detector forward pass

8360e5b

sachinprasadhs added the kokoro:force-run Runs Tests on GPU label Aug 20, 2024

kokoro-team removed the kokoro:force-run Runs Tests on GPU label Aug 20, 2024

divyashreepathihalli approved these changes Aug 20, 2024

View reviewed changes

divyashreepathihalli merged commit 2f9eb86 into keras-team:master Aug 20, 2024

sineeli deleted the sineeli/faster-rcnn branch August 23, 2024 18:25

Conversation

sineeli commented Jun 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Uh oh!

sineeli commented Jun 25, 2024

Uh oh!

Uh oh!

sineeli commented Jun 25, 2024

Uh oh!

ariG23498 commented Jun 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sineeli commented Jun 25, 2024

Uh oh!

VarunS1997 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

divyashreepathihalli left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

divyashreepathihalli commented Aug 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

sineeli commented Jun 25, 2024 •

edited

Loading

ariG23498 commented Jun 25, 2024 •

edited

Loading